Skip to content

Warn about build_docker_config being a Helm Chart option not a BinderHub option #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Warn about build_docker_config being a Helm Chart option not a BinderHub option #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions binderhub/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,10 @@ def docker_build_host_validate(self, proposal):
have an effect, as the push_secrets will overwrite
.docker/config.json
In this case, make sure that you include your config in your push_secret

WARNING: The value of this parameter is managed by the binderHub Helm Chart.
It is not managed by the BinderHub application itself.
If you are running BinderHub in another way this parameter has no effect.
""",
config=True,
)
Expand Down