Changes introduced by pre-commit run --all-files

[rgaiacs]

02768ab fails the tests.

One of the tests if fails is the pre-commit.

[rgaiacs]

The checks are failing

• Playwright Tests / tests (pull_request)
• Tests / test-local (pull_request)
• Tests / tests (v1.30, main) (pull_request)

@yuvipanda could you have a look at the Playwright tests? Thanks!

Playwright Tests

This fail is new.

=========================== short test summary info ============================
FAILED integration-tests/test_ui.py::test_loading_page[firefox-gh-binderhub-ci-repos/requirements-master---200] - AssertionError: 404 http://127.0.0.1:55879/services/binder/v2/gh/binderhub-ci-repos/requirements/master?
assert 404 == 200
 +  where 404 = <Response url='http://127.0.0.1:55879/services/binder/v2/gh/binderhub-ci-repos/requirements/master?' request=<Request url='http://127.0.0.1:55879/services/binder/v2/gh/binderhub-ci-repos/requirements/master?' method='GET'>>.status
FAILED integration-tests/test_ui.py::test_main_page[firefox-binder-examples/requirements----v2/gh/binder-examples/requirements/HEAD] - AssertionError: assert 404 == 200
 +  where 404 = <Response url='http://127.0.0.1:55879/services/binder/' request=<Request url='http://127.0.0.1:55879/services/binder/' method='GET'>>.status
FAILED integration-tests/test_ui.py::test_about_page[firefox] - AssertionError: assert 404 == 200
 +  where 404 = <Response url='http://127.0.0.1:55879/services/binder/about' request=<Request url='http://127.0.0.1:55879/services/binder/about' method='GET'>>.status
========================= 3 failed, 9 passed in 41.05s =========================

I'm not sure if the changes in binderhub/static/js/components/Progress.jsx done by pre-commit is the cause of the above 404 error.

test-local

The errors are the same of 02768ab

=========================== short test summary info ============================
FAILED binderhub/tests/test_build.py::test_build[git/https%3A%2F%2Fgithub.com%2Fbinderhub-ci-repos%2Fcached-minimal-dockerfile/HEAD] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[git/https%3A%2F%2Fgithub.com%2Fbinderhub-ci-repos%2Fcached-minimal-dockerfile/596b52f10efb0c9befc0c4ae850cc5175297d71c] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[gh/binderhub-ci-repos/cached-minimal-dockerfile/HEAD] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[gh/binderhub-ci-repos/cached-minimal-dockerfile/596b52f10efb0c9befc0c4ae850cc5175297d71c] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[gh/binderhub-ci-repos/cached-minimal-dockerfile/master] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[gl/binderhub-ci-repos%2Fcached-minimal-dockerfile/HEAD] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build[gl/binderhub-ci-repos%2Fcached-minimal-dockerfile/596b52f10efb0c9befc0c4ae850cc5175297d71c] - assert 0 > 0
FAILED binderhub/tests/test_build.py::test_build_fail - AssertionError: Should have seen phase 'failed'
assert 0 > 0
FAILED binderhub/tests/test_version.py::test_versions_handler - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
================ 9 failed, 145 deselected, 3 warnings in 1.59s =================

tests

The errors are the same of 02768ab

=========================== short test summary info ============================
FAILED binderhub/tests/test_repoproviders.py::test_dataverse[10.25346/S6/DE95RT-10.25346/S6/DE95RT-20460\\.v\\d+\\.\\d+$-https://doi.org/10.25346/S6/DE95RT-dataverse-s6-2fde95rt] - tornado.curl_httpclient.CurlError: HTTP 599: Could not resolve host: dataverse.ucla.edudataset.xhtml
===== 1 failed, 150 passed, 3 deselected, 12 warnings in 132.07s (0:02:12) =====

[consideRatio]

Is prettier v4 involved anywhere? Downgrading to v3 is needed i think. Ghere is a team compass issue around it

[rgaiacs]

I'm closing this in favor of #1986.