Skip to content

Export BinderHub JavaScript client as default #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Export BinderHub JavaScript client as default #2007

wants to merge 1 commit into from

Conversation

rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Aug 20, 2025

Closes #2006

This should avoid breaking change in the binderhub-client.

The previous way is

import { BinderRepository } from "@jupyterhub/binderhub-client";

and the new way is

import { BinderRepository } from "@jupyterhub/binderhub-client/client.js";

The new way is preferable as it is clear to the reader.

@rgaiacs rgaiacs requested a review from yuvipanda August 20, 2025 12:17
@rgaiacs rgaiacs self-assigned this Aug 20, 2025
@rgaiacs rgaiacs added the code:js-binderhub-client js changes to binderhub-client label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees

@rgaiacs rgaiacs

Labels
code:js-binderhub-client js changes to binderhub-client
Projects
PR triage (experimental)
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid breaking change in the binderhub client
1 participant
@rgaiacs