Skip to content

Only push published chart if --push specified #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Only push published chart if --push specified #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions chartpress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def build_images(
If unspecified the tag for each image will be the hash of the last commit
to modify the image's files.
push (bool):
Whether to push the resulting images (default: False).
Whether to push the resulting images and chart if published (default: False).
force_push (bool):
Whether to push the built images even if they already exist in the image
registry (default: False).
Expand Down Expand Up @@ -773,6 +773,7 @@ def publish_pages(
chart_repo_url,
extra_message="",
force=False,
push=True,
):
"""
Update a Helm chart registry hosted in the gh-pages branch of a GitHub git
Expand Down Expand Up @@ -886,7 +887,10 @@ def publish_pages(

_check_call(["git", "add", "."], cwd=checkout_dir)
_check_call(["git", "commit", "-m", message], cwd=checkout_dir)
_check_call(["git", "push", "origin", "gh-pages"], cwd=checkout_dir)
if push:
_check_call(["git", "push", "origin", "gh-pages"], cwd=checkout_dir)
else:
_log(f"Push disabled. Run `cd {checkout_dir} && git push origin gh-pages`")


class ActionStoreDeprecated(argparse.Action):
Expand Down Expand Up @@ -1085,6 +1089,7 @@ def main(args=None):
chart_repo_url=chart["repo"]["published"],
extra_message=args.extra_message,
force=args.force_publish_chart,
push=args.push,
)


Expand Down