Skip to content

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 25, 2025

  • don't build standard error responses for websocket errors, just send the error code and empty response. Websockets can't access error responses anyway.
  • make sure to resume error request if incoming response is already over, otherwise we'll get leftover sockets (this is why we kept accumulating ESTABLISHED sockets - we never consumed the error request because the incoming response had already been closed by that point, and you need to resume() to consume a response if you aren't going to use it.

for more information, see #557

- don't fetch errorTarget for websockets
- make sure to resume error request if incoming response is already over,
  otherwise we'll get leftover sockets
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work tracking the details of this down @minrk!!!

This looks good to me!

@consideRatio consideRatio merged commit 810239e into jupyterhub:main Sep 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants