Skip to content

Comments

fit: SSH connection interrupted#558

Open
luffywang1212-art wants to merge 1 commit intojupyterhub:mainfrom
luffywang1212-art:fit_SSH_connection_interrupted
Open

fit: SSH connection interrupted#558
luffywang1212-art wants to merge 1 commit intojupyterhub:mainfrom
luffywang1212-art:fit_SSH_connection_interrupted

Conversation

@luffywang1212-art
Copy link

@luffywang1212-art luffywang1212-art commented Feb 12, 2026

This adds periodic WebSocket ping keepalive to RawSocketHandler by launching an asyncio task in proxy_open that sends a ping every 30 seconds. The ping triggers automatic pong responses from browsers, which counts as activity and prevents intermediate proxies (e.g., Nginx) from closing idle connections after ~60 seconds.
Fixes #557

@ryanlovett
Copy link
Collaborator

Hi @luffywang1212-art , thanks for your contribution. I think if we were to add this capability, it would at least need to be configurable, perhaps via server process option, and the default would be disabled.

However as far as I can tell, reverse proxies like nginx, haproxy, and envoy typically don't inject such websocket pings, and the keepalives are handled in the client or server. Curious what others might have to say...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH connection interrupted

2 participants