fit: SSH connection interrupted#558
Open
luffywang1212-art wants to merge 1 commit intojupyterhub:mainfrom
Open
fit: SSH connection interrupted#558luffywang1212-art wants to merge 1 commit intojupyterhub:mainfrom
luffywang1212-art wants to merge 1 commit intojupyterhub:mainfrom
Conversation
Collaborator
|
Hi @luffywang1212-art , thanks for your contribution. I think if we were to add this capability, it would at least need to be configurable, perhaps via server process option, and the default would be disabled. However as far as I can tell, reverse proxies like nginx, haproxy, and envoy typically don't inject such websocket pings, and the keepalives are handled in the client or server. Curious what others might have to say... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds periodic WebSocket ping keepalive to
RawSocketHandlerby launching an asyncio task inproxy_openthat sends a ping every 30 seconds. The ping triggers automatic pong responses from browsers, which counts as activity and prevents intermediate proxies (e.g., Nginx) from closing idle connections after ~60 seconds.Fixes #557