Skip to content

Increase and centralize build memory limits #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Increase and centralize build memory limits #3211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions config/hetzner-2i2c-bare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ binderhub:
image_prefix: registry.2i2c-bare.mybinder.org/i-
# image_prefix: quay.io/mybinder-hetzner-2i2c/image-
# build_docker_host: /var/run/dind/docker.sock
# TODO: we should have CPU requests, too
# use this to limit the number of builds per node
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
KubernetesBuildExecutor:
memory_request: "2G"
memory_limit: "4G"
docker_host: /var/run/dind/docker.sock
repo2docker_extra_args:
# try to avoid timeout pushing to local registry
Expand Down
5 changes: 0 additions & 5 deletions config/hetzner-2i2c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ binderhub:
image_prefix: registry.2i2c.mybinder.org/i-
# image_prefix: quay.io/mybinder-hetzner-2i2c/image-
# build_docker_host: /var/run/dind/docker.sock
# TODO: we should have CPU requests, too
# use this to limit the number of builds per node
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
KubernetesBuildExecutor:
memory_request: "2G"
memory_limit: "4G"
docker_host: /var/run/dind/docker.sock
repo2docker_extra_args:
# try to avoid timeout pushing to local registry
Expand Down
1 change: 0 additions & 1 deletion config/staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ binderhub:
badge_base_url: https://staging.mybinder.org
image_prefix: us-central1-docker.pkg.dev/binderhub-288415/staging/r2d-2023-04-
sticky_builds: true
build_memory_limit: "2G"
DockerRegistry:
token_url: "https://us-central1-docker.pkg.dev/v2/token"

Expand Down
4 changes: 2 additions & 2 deletions mybinder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ binderhub:
}
KubernetesBuildExecutor:
build_image: quay.io/jupyterhub/repo2docker:2024.07.0-68.gdd097a2
memory_limit: "3G"
memory_request: "1G"
memory_limit: "6G"
memory_request: "2G"

extraConfig:
# Send Events to StackDriver on Google Cloud
Expand Down