Skip to content

Set template config correctly #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set template config correctly #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mybinder/files/etc/jupyter/jupyter_notebook_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import notebook

c.NotebookApp.extra_template_paths.append("/etc/jupyter/templates")
c.ServerApp.extra_template_paths.append("/etc/jupyter/templates")


# For old notebook versions we have to explicitly enable the translation
Expand All @@ -21,7 +21,7 @@
# Disable JITSI integration for now
jitsi_url = ""

c.NotebookApp.jinja_template_vars.update(
c.ServerApp.jinja_template_vars.update(
{
"binder_url": binder_launch_host + binder_request,
"persistent_binder_url": binder_launch_host + binder_persistent_request,
Expand Down
2 changes: 1 addition & 1 deletion mybinder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ tags: {}

etcJupyter:
jupyter_notebook_config.json:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need the right filename, I think:

Suggested change
jupyter_notebook_config.json:
jupyter_server_config.json:

NotebookApp:
ServerApp:
allow_origin: "*"
tornado_settings:
trust_xheaders: true
Expand Down
Loading