Run imagecleaner more aggressively #3229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason we had to revert jupyterhub#3228 was that the image cache was growing big, and so was the buildkit cache. So this meant images were being stored in *three* places: 1. the buildkit cache (dind) 2. the image cache (dind) 3. the containerd store (by kubernetes, when it pulls) 1 and 2 were both set to about 300, so this caused the disk to fill up. Here, I more aggressively prune the image cache, as it is simply not used when buildkit is used. Once I verify this works ok, I'll turn on buildkit building again and we see how it goes.
for more information, see https://pre-commit.ci
yuvipanda
changed the title
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 19, 2025
When we aren't using disk on the host for anything else, kubernetes can simply use as much of the disk as it wants for caching images. The default for this is upto 85%. However, since we *do* use the disk for our dind, we want to tune this to take up only half that size. I've already applied this to the 2i2c-hetzner node Follow-up to jupyterhub#3229
This was referenced Feb 19, 2025
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 19, 2025
Missed git add follow-up to jupyterhub#3229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we had to revert #3228 was that the image cache was growing big, and so was the buildkit cache. So this meant images were being stored in three places:
1 and 2 were both set to about 300, so this caused the disk to fill up.
Here, I more aggressively prune the image cache, as it is simply not used when buildkit is used. Once I verify this works ok, I'll turn on buildkit building again and we see how it goes.