-
Notifications
You must be signed in to change notification settings - Fork 381
Add buildpack for pyproject.toml to configure container image #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rgaiacs
wants to merge
15
commits into
jupyterhub:main
Choose a base branch
from
rgaiacs:1427-support-pyproject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
833f625
Start implementation of support for pyproject.yml
rgaiacs 0ab525f
Add builldpack for pyproject to list of buildpack
rgaiacs d93b9ed
Avoid change PATH during bash command
rgaiacs a703573
Change Python version used by ReadTheDocks
rgaiacs a077c71
Reduce code duplication in PyprojectBuildPack
rgaiacs a6f4fc7
Use tomli for Python < 3.11
rgaiacs d5c2cb6
Check that pyproject.toml has required fields
rgaiacs 74d4c1f
Add one test for pyproject
rgaiacs 316246c
Add documentation about pyproject.toml
rgaiacs 1723857
Fix English typos
rgaiacs c13a796
Only read pyproject.toml if file exists
rgaiacs 08c32c3
Merge PyprojectBuildPack into PythonBuildPack
rgaiacs 5fcb062
Add packaging as dependence
rgaiacs f3d2e06
Improve Python version detection in PythonBuildPack
rgaiacs de8027f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ sphinx: | |
| build: | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3.10" | ||
| python: "3.11" | ||
|
|
||
| python: | ||
| install: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ dependencies = [ | |
| "semver", | ||
| "toml", | ||
| "traitlets", | ||
| "packaging", | ||
| ] | ||
|
|
||
| [project.urls] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Python - pyproject.toml | ||
| ----------------------- | ||
|
|
||
| ``pyproject.toml`` should be used over ``setup.py``. |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [build-system] | ||
| requires = ["hatchling"] | ||
| build-backend = "hatchling.build" | ||
|
|
||
| [project] | ||
| name = "mwt" | ||
| version = "1.0.0" | ||
| dependencies = [ | ||
| "numpy", | ||
| ] | ||
| requires-python = ">=3.10" | ||
| authors = [ | ||
| {name = "Project Jupyter Contributors", email = "[email protected]"}, | ||
| ] | ||
| maintainers = [ | ||
| {name = "Project Jupyter Contributors", email = "[email protected]"}, | ||
| ] | ||
| description = "Test for repo2docker" | ||
| readme = "README.rst" | ||
| license = "MIT" | ||
|
|
||
| [project.urls] | ||
| Homepage = "https://repo2docker.readthedocs.io/" | ||
| Documentation = "https://repo2docker.readthedocs.io/" | ||
| Repository = "https://github.com/jupyterhub/repo2docker.git" | ||
| "Bug Tracker" = "https://github.com/jupyterhub/repo2docker/issues" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env python | ||
| try: | ||
| import mwt | ||
| except ImportError: | ||
| raise Exception("'mwt' shouldn't have been installed!") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space: