Add support to both .yml and .yaml#1501
Merged
minrk merged 5 commits intojupyterhub:mainfrom Jan 23, 2026
Merged
Conversation
minrk
reviewed
Jan 16, 2026
| if not os.path.exists(environment_yml): | ||
| self._environment_yaml = {} | ||
| return self._environment_yaml | ||
| for filename in ["environment.yml", "environment.yaml"]: |
Member
There was a problem hiding this comment.
These repetitions make me think perhaps we want a self.environment_yaml attribute or property that's resolved once.
Contributor
Author
There was a problem hiding this comment.
We already have a self.environment_yaml attribute
repo2docker/repo2docker/buildpacks/conda/__init__.py
Lines 232 to 256 in ca21e1b
Contributor
Author
|
Refactoring required a fresh brain to accurately read the properties name. :-D All tests are passing, including the small test added to check for this new feature. This pull request is ready for review. |
Member
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1373