Skip to content

Add pullPolicy to pre-pulled extraImages #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add pullPolicy to pre-pulled extraImages #3621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jupyterhub/templates/image-puller/_helpers-daemonset.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ spec:
{{- range $k, $v := .Values.prePuller.extraImages }}
- name: image-pull-{{ $k }}
image: {{ $v.name }}:{{ $v.tag }}
{{- with $v.pullPolicy }}
imagePullPolicy: {{ . }}
{{- end }}
command:
- /bin/sh
- -c
Expand Down
3 changes: 2 additions & 1 deletion jupyterhub/values.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ properties:
v1.11.1
zhy270a
```
pullPolicy:
pullPolicy: &imagePullPolicy
enum: [null, "", IfNotPresent, Always, Never]
description: |
Configures the Pod's `spec.imagePullPolicy`.
Expand Down Expand Up @@ -2921,6 +2921,7 @@ properties:
type: string
tag:
type: string
pullPolicy: *imagePullPolicy
containerSecurityContext: *containerSecurityContext-spec
pause:
type: object
Expand Down
1 change: 1 addition & 0 deletions tools/templates/lint-and-validate-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,7 @@ prePuller:
mockImage2:
name: mock-user/mock-image2
tag: mock-tag
pullPolicy: Always

ingress:
enabled: true
Expand Down