Add explicit namespace fields for ArgoCD/FluxCD compatibility#3810
Open
duncan-i3-work wants to merge 2 commits intojupyterhub:mainfrom
Open
Add explicit namespace fields for ArgoCD/FluxCD compatibility#3810duncan-i3-work wants to merge 2 commits intojupyterhub:mainfrom
duncan-i3-work wants to merge 2 commits intojupyterhub:mainfrom
Conversation
…Override
{"fundingSource": "41201", "team": "FED.ICGSA.OPS.CP", "fshGit": "0c3ea19b", "fshDocker": "sha256:1b340a55"}
Member
|
Can you please explain why this is needed? I've deployed Z2JH using ArgoCD without namespace problems. |
|
We've hit this a handful of times with various deployments and I think this note from the ArgoCD team summarizes it. In our cases argocd is managing apps for multiple clusters and the application namespace is not the destination namespace of jupyterhub. Handling this at the chart level allows us to get around this limitation |
ae8a3e0 to
9f71bb2
Compare
Author
|
Anything need to be done here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
namespace:field to all namespaced Kubernetes resources and introducesnamespaceOverrideconfiguration following the Bitnami chart pattern. This improves ArgoCD/FluxCD compatibility and enables custom namespace deployments.Addresses
Addresses #3396 - Improves ArgoCD/FluxCD compatibility for GitOps deployments
Related to #3190 - Makes multi-namespace deployments more reliable
Changes
Configuration
namespaceOverridefield tovalues.yamlvalues.schema.yamljupyterhub.namespacehelper function in_helpers.tplREADME.mdwith usage documentationResources Updated (45 namespaced resources)
Adds explicit
namespace: {{ include "jupyterhub.namespace" . }}to all namespaced resources:Special References Updated (11 locations)
Replaces all
.Release.Namespacereferences with helper function:Cluster-Scoped Resources
Benefits
ArgoCD/FluxCD Compatibility
Multi-Namespace Support
Subchart Scenarios
Backward Compatibility
✅ Fully backward compatible - defaults to
.Release.NamespacewhennamespaceOverrideis not setUsage
Deploy all resources to a custom namespace:
Or via Helm CLI:
Testing
Files Modified
59 files total:
See full verification report in commit messages.