Add a default connector plugin #1
Conversation
brichet
force-pushed
the
in-memory-connector
branch
from
e399ffa to
b30dae5
Compare
|
Nice, this looks good. FYI #2 should include a couple of CI fixes, if that can help. |
brichet
force-pushed
the
in-memory-connector
branch
from
b30dae5 to
b948eb4
Compare
src/connectors/in-memory.ts
Outdated
| ids.push(key); | ||
| } | ||
| }); | ||
| return { ids, values: [] }; |
There was a problem hiding this comment.
Should the values contain the actual secrets?
There was a problem hiding this comment.
We could, but currently it would be useless because of the interface of the SecretManager
jupyter-secrets-manager/src/token.ts
Line 21 in f909d00
jupyter-secrets-manager/src/manager.ts
Lines 25 to 27 in f909d00
I would be useful if there was a UI displaying all the secrets.
Maybe we can change it now (probably in another PR to also update the SecretManager), to avoid future breaking changes.
There was a problem hiding this comment.
ok, probably fine either way.
For now the most important is being able to set and get individual secrets.
There was a problem hiding this comment.
OK, I updated it and opened #3
|
Thanks for the review @jtpio |
* Add a default connector * Connector list() method returns also the values
2 participants
This PR adds a default connector plugin, storing the password in memory.
The passwords live only during the current session.