-
Notifications
You must be signed in to change notification settings - Fork 6
Add a default connector plugin #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { ISecret, ISecretsConnector } from '../token'; | ||
|
|
||
| /** | ||
| * An in memory password connector to store passwords during the session. | ||
| * Refreshing the page clear the passwords. | ||
| * | ||
| * This is the default implementation of ISecretsConnector. | ||
| */ | ||
| export class InMemoryConnector implements ISecretsConnector { | ||
| async fetch(id: string): Promise<ISecret | undefined> { | ||
| return this._secrets.get(id); | ||
| } | ||
|
|
||
| async save(id: string, value: ISecret): Promise<any> { | ||
| this._secrets.set(id, value); | ||
| } | ||
|
|
||
| async remove(id: string): Promise<any> { | ||
| this._secrets.delete(id); | ||
| } | ||
|
|
||
| async list( | ||
| query?: string | undefined | ||
| ): Promise<{ ids: string[]; values: ISecret[] }> { | ||
| const ids: string[] = []; | ||
| this._secrets.forEach((value, key) => { | ||
| if (value.namespace === query) { | ||
| ids.push(key); | ||
| } | ||
| }); | ||
| return { ids, values: [] }; | ||
| } | ||
|
|
||
| private _secrets = new Map<string, ISecret>(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './in-memory'; | ||
| export * from './local-storage'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
valuescontain the actual secrets?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but currently it would be useless because of the interface of the
SecretManagerjupyter-secrets-manager/src/token.ts
Line 21 in f909d00
jupyter-secrets-manager/src/manager.ts
Lines 25 to 27 in f909d00
I would be useful if there was a UI displaying all the secrets.
Maybe we can change it now (probably in another PR to also update the
SecretManager), to avoid future breaking changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, probably fine either way.
For now the most important is being able to set and get individual secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I updated it and opened #3