Skip to content

Add support for pdf and zip binary types #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

Add support for pdf and zip binary types #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff7354
Add support for pdf and zip binary types
JCapul Oct 9, 2025
27c989c
Refactor base64 conditions in single if
JCapul Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/drive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,16 @@ export class FileSystemDrive implements Contents.IDrive {
let format: Contents.FileFormat;
let fileContent: any = null;

// We assume here image, audio and video mimetypes are all and only binary files we'll encounter
// We assume here image, audio, video, zip and pdf mimetypes are all and only binary files we'll encounter
if (
file.type &&
file.type.split('/') &&
['image', 'audio', 'video'].includes(file.type.split('/')[0])
((file.type.split('/') &&
['image', 'audio', 'video'].includes(file.type.split('/')[0])) ||
[
'application/zip',
'application/pdf',
'application/octet-stream'
].includes(file.type))
) {
format = 'base64';
} else {
Expand Down