Skip to content

Conversation

@brichet
Copy link
Collaborator

@brichet brichet commented Jan 13, 2025

Checklist

  • ran doit lint locally

References

Follow up #11 to fix the navigation back to a sub-slide or fragment when using shift+space.
See #10 (comment) for context

Code changes

Uses extent redirection when moving back to a slide using shift+space.

User-facing changes

none

Backwards-incompatible changes

None

cc. @nthiery

@brichet brichet added the bug Something isn't working label Jan 13, 2025
@nthiery
Copy link
Contributor

nthiery commented Jan 13, 2025

I confirm that it works smoothly on my examples! Thank you!

@brichet brichet merged commit f14b9e5 into jupyterlab-contrib:main Jan 14, 2025
1 check passed
@brichet brichet deleted the back_navigation_space branch January 14, 2025 07:49
@nthiery
Copy link
Contributor

nthiery commented Jan 29, 2025

Hello @brichet,
Today on another notebook, I had the old behavior of not getting back to the previous fragment but beginning of previous slide. Just checking: this was merged in jupyterlab-slideshow=0.3.1, right? If yes, I'll try to minimize my notebook and post it here.

@brichet
Copy link
Collaborator Author

brichet commented Jan 30, 2025

@nthiery no, we did not released this change yet. I'll do a 0.3.2 today and let you know.

@nthiery
Copy link
Contributor

nthiery commented Jan 30, 2025

Ah, this explains that. Good. Thank you!

@brichet
Copy link
Collaborator Author

brichet commented Jan 30, 2025

@nthiery it has been released in v0.3.2

@nthiery
Copy link
Contributor

nthiery commented Jan 30, 2025

Great! I confirm that it works smoothly!

@nthiery
Copy link
Contributor

nthiery commented Jan 30, 2025

Including in JupyterLite.

Ah, well, up to a new glitch: the notebook toolbar does not include anymore the deck icon. But one can still run the slide show through the command palette or configure settings. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants