Skip to content

Update binder #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2021
Merged

Update binder #189

merged 4 commits into from
Jan 16, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jan 7, 2021

@fcollonval fcollonval marked this pull request as ready for review January 10, 2021 13:08
@fcollonval
Copy link
Member Author

This is ready now that #190 is in. But it will not work for now due to some issue in binder for the new jupyter server - see https://github.com/krassowski/jupyterlab-lsp/pull/452#issuecomment-755046446

So I think it can be merged as is as the error needs to be fixed by the binder team.

@ryantam626 ryantam626 merged commit 150657c into jupyterlab-contrib:master Jan 16, 2021
@ryantam626
Copy link
Collaborator

Gotcha, thanks for these 👍

@fcollonval fcollonval deleted the patch-1 branch January 16, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants