Fix Amazon Nova support (use StrOutputParser)
#1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
force-pushed
the
fix-amazon-nova-chat
branch
from
e5a808f to
ad70210
Compare
|
Interestingly, all of the other slash commands work with Amazon Nova, even though this PR only changes The only exception is |
dlqqq
changed the title
StrOutputParser)
srdas
approved these changes
Jan 16, 2025
dlqqq
force-pushed
the
fix-amazon-nova-chat
branch
from
ad70210 to
ed3bcf8
Compare
3coins
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
@dlqqq
LGTM!
The original code expecting chunk.content to be a string might not cover all Message responses, which is causing this error.
Using StrOutputParser should handle these different content types and any future changes that might happen in LangChain.
|
Thanks for the reviews folks! Merging. |
Darshan808
pushed a commit
to Darshan808/jupyter-ai
that referenced
this pull request
Feb 4, 2025
* use StrOutputParser in default chat * encourage using StrOutputParser in docs * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StrOutputParserto the runnable defined inDefaultChatHandler.AIMessageChunkobjects with a unique structure that we did not expect. This only happens when Amazon Nova is used throughChatBedrock, as far I'm aware.StrOutputParserto the runnable, the runnable now yields primitive strings when streamed, which we already handle inBaseChatHandler.stream_reply().Demo
Screen.Recording.2025-01-15.at.3.20.46.PM.mov
Open questions
(mainly for @3coins)