Skip to content

[2.x] Fix Amazon Nova support (use StrOutputParser) #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2025
Merged

[2.x] Fix Amazon Nova support (use StrOutputParser) #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39ab6e0
use StrOutputParser in default chat
dlqqq Jan 15, 2025
78ba46a
encourage using StrOutputParser in docs
dlqqq Jan 15, 2025
b69e2f7
pre-commit
dlqqq Jan 15, 2025
c6cfe8f
use StrOutputParser in /fix
dlqqq Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/developers/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def create_llm_chain(
prompt_template = FIX_PROMPT_TEMPLATE
self.prompt_template = prompt_template

runnable = prompt_template | llm # type:ignore
runnable = prompt_template | llm | StrOutputParser() # type:ignore
self.llm_chain = runnable
```

Expand Down
3 changes: 2 additions & 1 deletion packages/jupyter-ai/jupyter_ai/chat_handlers/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from jupyter_ai.models import HumanChatMessage
from jupyter_ai_magics.providers import BaseProvider
from langchain_core.output_parsers import StrOutputParser
from langchain_core.runnables import ConfigurableFieldSpec
from langchain_core.runnables.history import RunnableWithMessageHistory

Expand Down Expand Up @@ -37,7 +38,7 @@ def create_llm_chain(
self.llm = llm
self.prompt_template = prompt_template

runnable = prompt_template | llm # type:ignore
runnable = prompt_template | llm | StrOutputParser() # type:ignore
if not llm.manages_history:
runnable = RunnableWithMessageHistory(
runnable=runnable, # type:ignore[arg-type]
Expand Down
3 changes: 2 additions & 1 deletion packages/jupyter-ai/jupyter_ai/chat_handlers/fix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from jupyter_ai.models import CellWithErrorSelection, HumanChatMessage
from jupyter_ai_magics.providers import BaseProvider
from langchain.prompts import PromptTemplate
from langchain_core.output_parsers import StrOutputParser

from .base import BaseChatHandler, SlashCommandRoutingType

Expand Down Expand Up @@ -76,7 +77,7 @@ def create_llm_chain(
self.llm = llm
prompt_template = FIX_PROMPT_TEMPLATE

runnable = prompt_template | llm # type:ignore
runnable = prompt_template | llm | StrOutputParser() # type:ignore
self.llm_chain = runnable

async def process_message(self, message: HumanChatMessage):
Expand Down
Loading