Skip to content

Load local personas from .jupyter/personas instead of .jupyter/ #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/jupyter-ai/jupyter_ai/personas/persona_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,22 @@ def _init_local_persona_classes(self) -> None:
dotjupyter_dir = self.get_dotjupyter_dir()
if dotjupyter_dir is None:
self.log.info("No .jupyter directory found for loading local personas.")
else:
self._local_persona_classes = load_from_dir(dotjupyter_dir, self.log)
return

dotjupyter_personas = load_from_dir(dotjupyter_dir, self.log)
if dotjupyter_personas:
self.send_system_message(
"Found persona files in `.jupyter` directory. Please move them to `.jupyter/personas/` subdirectory."
)

personas_subdir = os.path.join(dotjupyter_dir, "personas")
if not os.path.exists(personas_subdir):
self.log.info(
"No `personas` subdirectory found in `.jupyter` directory for loading local personas."
)
return

self._local_persona_classes = load_from_dir(personas_subdir, self.log)

def _init_personas(self) -> dict[str, BasePersona]:
"""
Expand Down
2 changes: 1 addition & 1 deletion packages/jupyter-ai/jupyter_ai/tests/test_personas.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from unittest.mock import Mock

import pytest
from jupyter_ai.personas.base_persona import BasePersona, PersonaDefaults
from jupyter_ai.personas.base_persona import BasePersona
from jupyter_ai.personas.persona_manager import load_from_dir


Expand Down
Loading