Skip to content

Adding multi chats panel in @jupyter/chat package #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nakul-py
Copy link

@nakul-py nakul-py commented Aug 8, 2025

Adding multi chats pannel to @jypyter/chat package and removing it from jyputerlab-chat. Now it can be easily imported and usable in juputerlab-chat and jupyterlite/ai.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Binder 👈 Launch a Binder on branch nakul-py/jupyter-chat/multichatpanel

@brichet
Copy link
Collaborator

brichet commented Aug 8, 2025

Thanks @nakul-py for working on this.

I feel like this PR is not ready for review yet (e.g. we should not need the content manager in that chat, IMO).
Don't you think it should be converted to draft?

FYI I added some thoughts about this change in the issues.

@nakul-py nakul-py marked this pull request as draft August 8, 2025 11:37
@nakul-py
Copy link
Author

nakul-py commented Aug 12, 2025

@brichet These things have done:

  • Defined ready promise in the AbstractChatModel.
  • Defined IInputToolbarRegistry in @jupyter/chat.
  • Added the Rename chat button.

Will you Test it now and suggest some improvements?

@nakul-py nakul-py marked this pull request as ready for review August 12, 2025 11:58
@brichet
Copy link
Collaborator

brichet commented Aug 12, 2025

Thanks @nakul-py for updating it.
FYI I won't be able to review it until September.

@brichet brichet added the enhancement New feature or request label Aug 12, 2025
@nakul-py
Copy link
Author

Thanks @nakul-py for updating it. FYI I won't be able to review it until September.

Ok @brichet i am waiting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a multi chats side panel in @jupyter/chat package
2 participants