Add ui tests to showcase bug with saving of files with DOS line endings #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright test did not work unless you already have a test server stood up. Following the README as a new contributor this did not work.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a failing test and a passing test to showcase how the collab save functionality is broken for dos files (files with dos line endings with a carriage return).
See issue (#448) for full details.
Bug behaviour (video taken directly from UI test failure):
f115b213aac2233742500c393c6e6033c6d27bfd.webm
Also updated the UI readme so a new contributor can get started running tests straight away as the old README didn't work without a running jupyterlab instance manually (not documented in the README).