Skip to content

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Apr 8, 2025

While #459 fixed the version pins, the bump script reverted it during release.

This PR fix the bump script to pin the project versions to >=current_version,<next_major instead of only >=current_version.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/fix_bump_pins_version

@brichet brichet changed the base branch from main to 3.x April 8, 2025 21:32
@brichet brichet added the bug Something isn't working label Apr 8, 2025
@brichet brichet closed this Apr 8, 2025
@brichet brichet reopened this Apr 8, 2025
@brichet brichet changed the title Fix pins version in bump script Fix version pins in bump script Apr 8, 2025
@krassowski
Copy link
Member

Yeah, it also removed the pin on JupyterLab >= 4.4.0, see #462

@brichet
Copy link
Contributor Author

brichet commented Apr 9, 2025

Yeah, it also removed the pin on JupyterLab >= 4.4.0, see #462

Yeah, we'll need to add this when backporting this PR to main (currently it targets 3.x).
I think Jupyterlab was not pinned in 3.x branch yet: #446

@krassowski
Copy link
Member

@brichet would it make sense to also apply this to main branch?

Also, should we make the pin <X.0.0dev0?

@brichet
Copy link
Contributor Author

brichet commented Apr 9, 2025

@brichet would it make sense to also apply this to main branch?

Yes, to prevent future similar issues, when releasing collaboration v5 I guess.

Also, should we make the pin <X.0.0dev0?

Is this necessary ? I thought that <X was enough to avoid also the dev and alpha/beta releases of version X.

@brichet
Copy link
Contributor Author

brichet commented Apr 9, 2025

I will probably not be able to follow up on it today, please update the PR if needed @krassowski

@krassowski
Copy link
Member

Is this necessary?

I have not verified it, but heard it is.

I opened #463 for the other issue.

@brichet
Copy link
Contributor Author

brichet commented Apr 9, 2025

I have not verified it, but heard it is.

According to the doc, pip should not include pre-release or develop versions if not specified in requirements.
https://pip.pypa.io/en/stable/cli/pip_install/#pre-release-versions

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brichet!

@krassowski krassowski merged commit 2808e35 into jupyterlab:3.x Apr 9, 2025
31 of 33 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to main

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-collaboration that referenced this pull request Apr 9, 2025
@brichet brichet deleted the fix_bump_pins_version branch April 9, 2025 15:10
krassowski added a commit that referenced this pull request Apr 9, 2025
Co-authored-by: Nicolas Brichet <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants