-
-
Notifications
You must be signed in to change notification settings - Fork 41
Fix version pins in bump script #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, it also removed the pin on JupyterLab >= 4.4.0, see #462 |
@brichet would it make sense to also apply this to Also, should we make the pin |
Yes, to prevent future similar issues, when releasing collaboration
Is this necessary ? I thought that |
I will probably not be able to follow up on it today, please update the PR if needed @krassowski |
I have not verified it, but heard it is. I opened #463 for the other issue. |
According to the doc, pip should not include pre-release or develop versions if not specified in requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @brichet!
@meeseeksdev please backport to main |
Co-authored-by: Nicolas Brichet <[email protected]> Co-authored-by: Michał Krassowski <[email protected]>
While #459 fixed the version pins, the bump script reverted it during release.
This PR fix the bump script to pin the project versions to
>=current_version,<next_major
instead of only>=current_version
.