Skip to content

Open external links in system browser #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Open external links in system browser #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/main/labview/labview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import {
clipboard,
dialog,
Menu,
MenuItemConstructorOptions
MenuItemConstructorOptions,
shell
} from 'electron';
import log from 'electron-log';
import * as path from 'path';
Expand Down Expand Up @@ -63,6 +64,17 @@ export class LabView implements IDisposable {
}
});

// Open external links in system browser
this._view.webContents.setWindowOpenHandler(({ url }) => {
const jlab_host = `${sessionConfig.url.protocol}//${sessionConfig.url.host}`
if (url.startsWith(jlab_host)) {
return { action: 'allow'};
} else {
shell.openExternal(url);
return { action: 'deny' };
}
});

this._view.setBackgroundColor(
options.isDarkTheme ? DarkThemeBGColor : LightThemeBGColor
);
Expand Down