Remove cleanup working directory changes; always use absolute paths. #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup routines, and some other locations, relied on persistent changes to the working directory despite being in the context of yields where other changes might take place. This may be at fault for #249, for example, and generally seems unsafe.
In an attempt to prevent the working directory from being a problem, this PR removes all
os.chdircalls. It instead passes paths between methods, making them absolute on the first opportunity, and sets the working directories of subprocesses at the point of starting them. The cleanup mechanism still feels risky – it would be safer to restrict removals to a set of plausible temporary file patterns – but this should at least make things a bit safer, and doesn't involve needing to choose that set yet; I might try to come up with that later if I have time.I'm leaving this as a draft until I can test it.