[WIP] more fixes for kernel tests #6073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
We also added skips to tests that seem to currently fail. Fixing those is next.
Contributor
Author
|
The tests pass locally for me with these changes. I'm confused by the failures here. I think it's best to pause this work until we can discuss more fully exactly what is happening with the tests. |
Contributor
|
tornado 6 related perhaps? |
Contributor
Author
|
Oh, perhaps. Good thing to check, for sure. |
Member
|
Closing for now because it seems to have been superseded by more test work, recently. |
Contributor
Author
|
Superseded now with the recent kernel refactor work. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the tests changes from #4724. Likely there will be things to fix, as those tests were also modified to work with the changes in that PR. But there were also fixes for the asynchronous test flakiness that these changes hope to address.