Add an offset option for cursor location within mid-drag image#126
Draft
cameron-toy wants to merge 3 commits intojupyterlab:mainfrom
Draft
Add an offset option for cursor location within mid-drag image#126cameron-toy wants to merge 3 commits intojupyterlab:mainfrom
cameron-toy wants to merge 3 commits intojupyterlab:mainfrom
Conversation
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>
added drag offset to findScrollTarget made drag offset optional added optional drag offset
cameron-toy
force-pushed
the
drag_offset
branch
from
683d5ff to
9a25bf8
Compare
Member
|
Hi @cameron-toy! Thanks for the PR! This change seems useful to me. Could you please:
|
afshin
changed the title
afshin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds optional
dragAdjustXanddragAdjustYoptions forDragobjects. This allows the cursor to be somewhere other than the upper left corner of the drag image during a drag.Without adjust
With adjust
Background (shameless plug): I originally used this hacked version of lumino dragdrop for the JupyterLab Interactive Dashboard Editor and figured the changes would be useful in core.
Fixes #347