If too many tab complete options, use yes/no prompt to display them all #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
tab-complete-yes-no
branch
3 times, most recently
from
8e23c12 to
f7577c7
Compare
ianthomas23
force-pushed
the
tab-complete-yes-no
branch
from
f7577c7 to
79e8ff0
Compare
ianthomas23
force-pushed
the
tab-complete-yes-no
branch
from
79e8ff0 to
0f6d558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the are too many options to display when using tab completion, display a
yes/noprompt to display all or none of them:Too many here means > 99 (arbitrary threshold) or too many to display in the available terminal size. The terminal size can be hacked using
export LINES=<number>and/orexport COLUMNS=<number>to manually test this.'y' is the only input that will cause all options to be displayed,
n, Ctrl-C and Ctrl-D (ascii 3 and 4) will prevent the options being displayed.Currently this only works if using the ServiceWorker for synchronous stdin, there is a bug in the SharedArrayBuffer implementation that sometimes causes the confirmation y/n key to be echoed to the next terminal prompt.
Closes #129.