Skip to content

WIP, publish error tracebacks on iopub #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP, publish error tracebacks on iopub #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pyodide-kernel/py/pyodide-kernel/pyodide_kernel/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class LiteDisplayHook(DisplayHook):
def __init__(self, *args, **kwargs):
super(LiteDisplayHook, self).__init__(*args, **kwargs)
self.publish_execution_result = None
self.publish_execution_error = None

def start_displayhook(self):
self.data = {}
Expand Down
6 changes: 6 additions & 0 deletions packages/pyodide-kernel/py/pyodide-kernel/pyodide_kernel/interpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ def enable_gui(self, gui=None):
pass

def _showtraceback(self, etype, evalue, stb):
sys.stdout.flush()
sys.stderr.flush()
dh = self.displayhook
if dh.publish_execution_error:
dh.publish_execution_error(str(etype), str(evalue), stb)

self._last_traceback = {
"ename": str(etype),
"evalue": str(evalue),
Expand Down
3 changes: 2 additions & 1 deletion packages/pyodide-kernel/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ ${e.stack}`;
const bundle = {
ename: ename,
evalue: evalue,
traceback: traceback,
traceback: this.formatResult(traceback),
};

this._sendWorkerMessage({
Expand Down Expand Up @@ -363,6 +363,7 @@ ${e.stack}`;
this._interpreter.display_pub.update_display_data_callback =
updateDisplayDataCallback;
this._interpreter.displayhook.publish_execution_result = publishExecutionResult;
this._interpreter.displayhook.publish_execution_error = publishExecutionError;
this._interpreter.input = this.input.bind(this);
this._interpreter.getpass = this.getpass.bind(this);

Expand Down
Loading