You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the switch to using TerminalAPIClient is hasn't been necessary to disable JupyterLab's default terminal manager extension, at least in local test deployments. But there are some deployments in which this causes a problem, so here disabling the extension.
Take a look at my PRs to add the terminal to our experimental internal project. A local dev build on my machine didn't need this disabling, but a complicated CI deployment did.
Coming back to this, I think it is not necessary in general. The exception to this occurred in an experimental project that changes the order of loading extensions. So maybe this disabling should be removed here?
Yes I believe so, especially since the config in this repo is only for the demos and UI tests, and should not affect downstream projects using the terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the switch to using
TerminalAPIClientis hasn't been necessary to disable JupyterLab's default terminal manager extension, at least in local test deployments. But there are some deployments in which this causes a problem, so here disabling the extension.