Skip to content

Support use of lite_dir when deploying #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 1 commit into from
Sep 24, 2025
Merged

Support use of lite_dir when deploying #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions jupyterlite_terminal/add_on.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,25 @@ def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

def post_build(self, manager):
lite_dir = manager.lite_dir
output_dir = manager.output_dir

cockleTool = Path("node_modules", "@jupyterlite", "cockle", "lib", "tools", "prepare_wasm.js")
if not cockleTool.is_file():
cockleTool = ".cockle_temp" / cockleTool
cmd = ["npm", "install", "--no-save", "--prefix", cockleTool.parts[0], "@jupyterlite/cockle"]
print("TerminalAddon:", " ".join(cmd))
subprocess.run(cmd, check=True)
subprocess.run(cmd, check=True, cwd=lite_dir)

assetDir = Path(self.manager.output_dir) / "extensions" / "@jupyterlite" / "terminal" / "static" / "wasm"
assetDir = output_dir / "extensions" / "@jupyterlite" / "terminal" / "static" / "wasm"

# Although cockle's prepare_wasm is perfectly capable of copying the wasm and associated
# files to the asset directory, here we just get the list of required files and let the
# add-on do the copying for consistency with other extensions.
tempFilename = 'cockle-files.txt'
cmd = ["node", str(cockleTool), "--list", tempFilename]
tempFilename = lite_dir / 'cockle-files.txt'
cmd = ["node", str(cockleTool), "--list", str(tempFilename)]
print("TerminalAddon:", " ".join(cmd))
subprocess.run(cmd, check=True)
subprocess.run(cmd, check=True, cwd=lite_dir)

with open(tempFilename, 'r') as f:
for source in f:
Expand All @@ -44,7 +47,7 @@ def post_build(self, manager):
packageName = next(f).strip()
yield dict(
name=f"copy:{basename}",
actions=[(self.copy_one, [source, assetDir / packageName / basename])],
actions=[(self.copy_one, [lite_dir / source, assetDir / packageName / basename])],
)

os.remove(tempFilename)
Loading