Fix shared libs loading + adding more advanced tests #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
fix_shared_libs_loading
branch
from
e6ceb54 to
82cf9e0
Compare
martinRenou
changed the title
martinRenou
force-pushed
the
fix_shared_libs_loading
branch
from
82cf9e0 to
566d6cf
Compare
|
All green 😃 |
jtpio
reviewed
Sep 2, 2025
| const notebook = 'Lorenz.ipynb'; | ||
|
|
||
| await page.notebook.open(notebook); | ||
| await page.notebook.runCellByCell(); |
There was a problem hiding this comment.
Don't we want to check there is no error after executing all the cells?
There was a problem hiding this comment.
Ah indeed! This was properly hanging forever on the non-running Lorenz example, so it seems to verify correctly the kernel crashed, but it does not check the code actually runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #275 for now for testing