Merged
Conversation
Member
|
Yes parsetab.py is generated and we introduced new rules, that's why, so it's ok. It seems all good to me, thank you for spotting the python requirement in README. I would publish it with version 0.15.0 as there are features added (it's not just a bug fix), although there is no backward incompatible changes. We could even consider it a 1.0.0 release, to make it official it's quite stable now ! |
Member
|
And thank you so much for taking the time to publish it @mmoriniere ! |
alexgarel
approved these changes
Feb 17, 2025
Contributor
Author
|
@alexgarel It's merged and published on PyPI, version 1.0.0. |
Member
|
Great ! Thank you so much @mmoriniere 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alexgarel
It took me some time to get the PyPI publication to work, and I also had quite a huge parsetab.py diff in the process.
Is it OK to merge this parsetab.py update ?
Do you agree that this also needs a new 0.14.1 release and PyPI publication ?