Skip to content

Allow importing of external URLs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow importing of external URLs #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7039dd
feat: Allow importing of external links
May 2, 2024
ecd78a5
Merge pull request #1 from marcusorjames/update/links
marcusorjames May 2, 2024
66f47a6
Coding standards
marcusorjames May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"require": {
"php": ">=5.6.20",
"setasign/fpdf": "^1.8",
"setasign/fpdi": "^2.3"
"setasign/fpdi": "^2.4"
},
"authors": [
{
Expand Down
8 changes: 7 additions & 1 deletion src/Jurosh/PDFMerge/PDFMerger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

use Exception;
use setasign\Fpdi\Fpdi AS FPDI;
use setasign\Fpdi\PdfReader\PageBoundaries;

/**
* Basic merging of PDF files into one file
Expand All @@ -14,6 +15,11 @@ class PDFMerger {
* @var type Array of PDFObject-s
*/
private $_files;
private $_importExternalLinks;

public function __construct($importExternalLinks = false) {
$this->_importExternalLinks = $importExternalLinks;
}

/**
* Add a PDF for inclusion in the merge with a valid file path.
Expand Down Expand Up @@ -69,7 +75,7 @@ public function merge($outputmode = 'browser', $outputpath = 'newfile.pdf') {
//add the pages
if ($filepages == 'all') {
for ($i = 1; $i <= $count; $i++) {
$template = $fpdi->importPage($i);
$template = $fpdi->importPage($i, PageBoundaries::CROP_BOX, true, $this->_importExternalLinks);
$size = $fpdi->getTemplateSize($template);

$fpdi->AddPage($file->getOrientationCode(), array($size['width'], $size['height']));
Expand Down