Skip to content

Conversation

@PritishBudhiraja
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja commented Jan 20, 2025

Type of Change

  • New feature

Description

Added types support for loadHyper and added descriptions with examples. So via code editor it can look good.

let hyperPromise = loadHyper("pk_snd_12342", {
  options: {
    customBackendUrl: "https://api.abc.in",
  },
});
Screenshot 2025-01-20 at 10 25 22 AM Screenshot 2025-01-20 at 10 25 29 AM Screenshot 2025-01-20 at 10 25 36 AM

How did you test it?

Via locally using the build and using the same in my demo store and converting the file from .js to .ts and errors and warnings were coming when I was using the req types.


Usage Notes

Yes it's a breaking change so we will be bumping our major version for this. Folks who are using the .js one won't face issue but .ts one might need to integrate properly with types.


Version Update

Will bump the version accordingly based on discussion.

Checklist

  • I ran npm run re:build and verified the build artifacts.
  • I reviewed the code for style, readability, and consistency.
  • I verified the changes are backward compatible (if applicable).
  • I tested this change in a real or simulated consuming project.
  • I updated documentation, README, or usage examples if necessary.

@PritishBudhiraja PritishBudhiraja changed the title feat: added types for hyper-js feat(hyper-js): add types for type exposure Jan 20, 2025
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Jan 20, 2025
@PritishBudhiraja PritishBudhiraja linked an issue May 21, 2025 that may be closed by this pull request
seekshiva
seekshiva previously approved these changes May 22, 2025
@PritishBudhiraja PritishBudhiraja merged commit cdf6013 into main May 22, 2025
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the types-added branch May 22, 2025 08:38
@github-actions github-actions bot removed the Ready for Review PR with label Ready for Review should only be reviewed. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Type Definitions for Type Exposure

4 participants