fix: Amount filter in payment operations and refunds #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Recent change tied filter refetch to date range, which caused remounts and cleared local state in the Amount filter. On Payments > Amount, selecting a value closes the dropdown and the selection isn’t retained.
This started after PR #3413 (fix: filter bugs when time range is changed). The refetch was triggered by start_time and end_time. While fetching, filter data was cleared temporarily, which flipped the subtree and caused a remount, resetting the dropdown state.
The fix reverts the effect dependency to only transactionEntity, matching the behavior before #3413 and preventing unnecessary remounts.
Motivation and Context
bugfix
How did you test it?
Amount filter dropdown now opens correctly on first click and retains input.
Also time range filters are working accurately.
Where to test it?
Checklist
npm run re:build