refactor: move probes and resources to values.yaml #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatviichuk
force-pushed
the
refactor/card-vault-configurable-probes-resources
branch
3 times, most recently
from
fdb0cda to
13c5ef8
Compare
Move livenessProbe, readinessProbe, and resources from hardcoded values in deployment.yaml to configurable values.yaml.
dmatviichuk
force-pushed
the
refactor/card-vault-configurable-probes-resources
branch
from
13c5ef8 to
a08a780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move hardcoded livenessProbe, readinessProbe, and resources configuration
from deployment.yaml to values.yaml under server section to match the
pattern used in other charts (hyperswitch-control-center, hyperswitch-app).
Changes:
to values.yaml with default values matching previous hardcoded values
with toYaml for consistent templating approach