fix: country data setting #1100
Conversation
sakksham7
requested review from
ArushKapoorJuspay,
PritishBudhiraja,
aritro2002 and
seekshiva
as code owners
|
Review changes with |
PritishBudhiraja
added
the
Ready for Review
| let optionsCallback = (optionsPayment: PaymentType.options) => { | ||
| let optionsCallback = async (optionsPayment: PaymentType.options) => { | ||
| try { | ||
| let _ = await S3Utils.initializeCountryData(~locale=config.locale, ~logger) |
There was a problem hiding this comment.
Since we are not using the value returned by initializeCountryData, you can return unit instead of data
| let getBillingAddressFields = (countryDataContent): array< | ||
| PaymentMethodsRecord.paymentMethodsFields, | ||
| > => { | ||
| open Utils |
There was a problem hiding this comment.
No need to call open Utils, you are only using it in one place
|
|
||
| let getClientCountry = clientTimeZone => { | ||
| CountryStateDataRefs.countryDataRef.contents | ||
| open CountryStateDataRefs |
There was a problem hiding this comment.
No need to write this line either
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
Type of Change
Description
Country Mapping set to empty array initially
Set Up country based upon fetched list from S3
Added Asia/Calcutta as Timezone
How did you test it?
Tested Locally
Checklist
npm run re:build