Skip to content

refactor: General cleanup - remove deprecated logic, improve naming consistency, and add inline documentation #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ritoban23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: General cleanup - remove deprecated logic, improve naming consistency, and add inline documentation #1261

ritoban23 wants to merge 2 commits into from

Conversation

@ritoban23
Copy link

@ritoban23 ritoban23 commented Oct 18, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

General cleanup to remove deprecated logic, improve naming consistency, and add inline documentation:

  • Fixed spelling: ErrorOccured → ErrorOccurred (component name)
  • Fixed spelling: broswerInfo → browserInfo (function name)
  • Fixed spelling: atleast → at least (warning messages)
  • Fixed variable name: puseduoArr → pseudoArr
  • Removed debug console logs from PaymentMethodCollectElement.res
  • Improved TODO comments with clearer descriptions
  • Added inline documentation for constructClass function

fixes #1157

How did you test it?

  • Verified no compilation errors after changes
  • Confirmed all references to old misspelled component were updated

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 18, 2025

Review changes with  SemanticDiff

sakksham7
sakksham7 reviewed Oct 24, 2025
View reviewed changes
sakksham7
sakksham7 reviewed Oct 24, 2025
View reviewed changes
sakksham7
sakksham7 reviewed Oct 24, 2025
View reviewed changes
@AbhishekChorotiya
Copy link
Contributor

AbhishekChorotiya commented Oct 31, 2025

Hey @ritoban23 ,
Thank you for your contribution!
Please fill this form: Link

@AbhishekChorotiya AbhishekChorotiya added the Good First Issue Good for newcomers label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakksham7 sakksham7 sakksham7 left review comments

@AbhishekChorotiya AbhishekChorotiya AbhishekChorotiya approved these changes

@aritro2002 aritro2002 aritro2002 approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

+1 more reviewer

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Good First Issue Good for newcomers hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

- General Cleanup - Remove deprecated or unused logic, improve naming consistency, and add concise inline documentation where useful.

5 participants

@ritoban23 @AbhishekChorotiya @PritishBudhiraja @sakksham7 @aritro2002