fix: support both api-key header formats for V2 authentication#10802
Closed
ItsYash1421 wants to merge 3 commits intojuspay:mainfrom
Closed
fix: support both api-key header formats for V2 authentication#10802ItsYash1421 wants to merge 3 commits intojuspay:mainfrom
ItsYash1421 wants to merge 3 commits intojuspay:mainfrom
Conversation
Changed Files
|
Member
|
Hey @ItsYash1421, thanks for the PR. Unfortunately, we would most likely not be proceeding with this PR, as we would prefer to stick to the existing authentication mechanism for the v2 APIs (as I understand, maybe @AnuthaDev can confirm). That said, @AnuthaDev has fixed the incorrect API docs in #10888. Thanks again for your time, feel free to pick up another issue if you're interested to contribute! |
Member
|
Closing this in favor of #10888. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixed V2 customer creation authentication to accept API keys in both the documented OpenAPI format and the legacy format for backward compatibility.
Changes:
Additional Changes
Motivation and Context
Fixes #10789
Problem: Users following the OpenAPI documentation received authentication errors when attempting to create V2 customers:
Checklist
cargo +nightly fmt --allcargo clippy