Skip to content

feat(authentication): added VM for authentication ctp#10803

Merged
likhinbopanna merged 5 commits intomainfrom
13575-add-authentication-metrics-for-modular-authentication
Jan 9, 2026
Merged

feat(authentication): added VM for authentication ctp#10803
likhinbopanna merged 5 commits intomainfrom
13575-add-authentication-metrics-for-modular-authentication

Conversation

@sahkal
Copy link
Contributor

@sahkal sahkal commented Dec 30, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added Victoria metrics for modular authentication click to pay

Motivation and Context

Currently modular authentication doesn't have any trail logs in dashboard to determine failure or to track authentication journey. With this pr we will be pushing authentication success count and token successfully pushed to VGS count to determine stability of the module

How did you test it?

This PR doesnt have any business impactful changes, can be tested one metrics are pushed to victoria metrics in grafana

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sahkal sahkal self-assigned this Dec 30, 2025
@sahkal sahkal requested a review from a team as a code owner December 30, 2025 11:59
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 30, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/unified_authentication_service.rs  46% smaller
  crates/router/src/core/metrics.rs  0% smaller

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@65603b4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10803   +/-   ##
=======================================
  Coverage        ?    6.38%           
=======================================
  Files           ?     1268           
  Lines           ?   319110           
  Branches        ?        0           
=======================================
  Hits            ?    20380           
  Misses          ?   298730           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…tion' of github.com:juspay/hyperswitch into 13575-add-authentication-metrics-for-modular-authentication
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit bfeb441 Jan 9, 2026
35 of 38 checks passed
@likhinbopanna likhinbopanna deleted the 13575-add-authentication-metrics-for-modular-authentication branch January 9, 2026 10:09
siaass842 pushed a commit that referenced this pull request Jan 14, 2026
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants