-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(connector): Handle Mollie failed payments with error details from details object #10824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
|
|
||
| let error_code = failure_reason | ||
| .clone() | ||
| .unwrap_or_else(|| "PAYMENT_FAILED".to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use const no error code here
| .unwrap_or_else(|| "PAYMENT_FAILED".to_string()); | ||
| let error_message = failure_message | ||
| .clone() | ||
| .unwrap_or_else(|| "Payment failed".to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use const no error message here
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10824 +/- ##
=======================================
Coverage ? 6.32%
=======================================
Files ? 1273
Lines ? 322280
Branches ? 0
=======================================
Hits ? 20395
Misses ? 301885
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Type of Change
Description
Mollie can return HTTP 2xx responses even when a payment fails (for example, after a 3DS authentication flow). In such cases, the payment status is marked as failed or expired, and failure information is provided inside the details object.
Previously, these failures were not being surfaced correctly as connector errors in Hyperswitch.
Additional Changes
Motivation and Context
How did you test it?
request create
Response
Psync after Redirect Response
few of the refund tests are giving 4xx : capture calls were in processing state




Checklist
cargo +nightly fmt --allcargo clippy