Skip to content

fix(external_services): Mask sender_email#10848

Merged
Gnanasundari24 merged 1 commit intomainfrom
email-rahasya
Jan 9, 2026
Merged

fix(external_services): Mask sender_email#10848
Gnanasundari24 merged 1 commit intomainfrom
email-rahasya

Conversation

@AnuthaDev
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Changed the type of sender_email to pii::Email in the external_services crate

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #10847

How did you test it?

Build and run router. In the logged application config, verified that the sender_email is masked.

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@AnuthaDev AnuthaDev self-assigned this Jan 7, 2026
@AnuthaDev AnuthaDev requested a review from a team as a code owner January 7, 2026 00:39
@AnuthaDev AnuthaDev added the A-framework Area: Framework label Jan 7, 2026
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 7, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  crates/external_services/src/email.rs  0% smaller
  crates/external_services/src/email/ses.rs  0% smaller
  crates/external_services/src/email/smtp.rs  0% smaller

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4df0779). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10848   +/-   ##
=======================================
  Coverage        ?    6.35%           
=======================================
  Files           ?     1269           
  Lines           ?   321037           
  Branches        ?        0           
=======================================
  Hits            ?    20389           
  Misses          ?   300648           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 5c28c75 Jan 9, 2026
26 of 27 checks passed
@Gnanasundari24 Gnanasundari24 deleted the email-rahasya branch January 9, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-framework Area: Framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sender Email is not masked in external_services

4 participants