-
Notifications
You must be signed in to change notification settings - Fork 4.6k
refactor(routing): de-couple dynamic and static routing #10854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prajjwalkumar17
wants to merge
10
commits into
main
Choose a base branch
from
de_couple_dynamic_routing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+306
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10854 +/- ##
=======================================
Coverage ? 6.33%
=======================================
Files ? 1273
Lines ? 322269
Branches ? 0
=======================================
Hits ? 20400
Misses ? 301869
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarnura
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request refactors the routing logic in the payments core to introduce a new extensible routing pipeline using the
RoutingStagetrait and associated stage structs. The changes modularize static and dynamic routing logic, encapsulate routing results, and simplify dynamic routing integration with Open Router. This makes the routing process more maintainable and extensible for future enhancements.Routing Pipeline Refactor and Abstractions:
RoutingStageasync trait and implemented it forStaticRoutingStageand (conditionally)DynamicRoutingStage, allowing routing logic to be composed as a pipeline of stages. Theapplymethod encapsulates each stage's logic and takes/returns a newRoutingOutcomestruct.RoutingOutcomestruct to carry connectors and routing approach through the pipeline, replacing ad-hoc tuple passing.Core Routing Logic Changes:
payments.rsto use the new pipeline: first applying the static routing stage, then (if enabled) the dynamic routing stage, updating the payment data with the final routing approach.RoutingOutcomestruct.Dynamic Routing Integration:
DynamicRoutingResultstruct, encapsulating connectors and routing approach, and updated all call sites to use this new result type. [1] [2] [3] [4] [5] [6] [7]Dependency and Import Updates:
RoutingStage.Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy