Skip to content

Use inspect to remove the dependency on nix fork for flake-schemas#277

Merged
srid merged 14 commits intomainfrom
remove-nix-fork-dep
Sep 19, 2024
Merged

Use inspect to remove the dependency on nix fork for flake-schemas#277
srid merged 14 commits intomainfrom
remove-nix-fork-dep

Conversation

@shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Sep 15, 2024

resolves #261

inspect is used to inspect a flake output based on a schema. See: https://github.com/juspay/inspect

See changes on the juspay/inspect fork: juspay/inspect@279cfa5

Todo:

@shivaraj-bh
Copy link
Member Author

image

@srid omnix-gui not disabled in CI?

@srid
Copy link
Member

srid commented Sep 15, 2024

omnix-gui not disabled in CI?

It is disabled in Nix; this PR's failure is from devshell's cargo test. Does 4be3a71 help?

@shivaraj-bh shivaraj-bh marked this pull request as ready for review September 18, 2024 12:24
#[test]
fn om_show_local() -> anyhow::Result<()> {
om()?.arg("show").arg(".").assert().success().stdout(
om()?.arg("show").arg("../..").assert().success().stdout(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix flake show walks up the directory tree to find the flake, while nix eval doesn't

@srid
Copy link
Member

srid commented Sep 19, 2024

intel mac builder is stuck for reason,

image

@srid
Copy link
Member

srid commented Sep 19, 2024

I don't know what this entails, but we can do this after this PR is merged, which I'll do now.

@srid srid merged commit 2641fa3 into main Sep 19, 2024
@srid srid deleted the remove-nix-fork-dep branch September 19, 2024 00:56
@srid srid mentioned this pull request Sep 21, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on nix fork

2 participants