nix: support virtual-root workspaces #49
Conversation
nix/modules/crate.nix
Outdated
| name = cargoToml.package.name or cargoToml.workspace.package.name; | ||
| description = | ||
| cargoToml.package.description or cargoToml.workspace.package.description | ||
| or (builtins.throw "Missing description in ${name}'s Cargo.toml"); |
There was a problem hiding this comment.
Can you point me to an example project here? AFAIU, workspace.package.* are common attributes to use in all workspace packages:
So, why would anyone want to use workspace.package.name when that means every workspace crate gets the same package name?
The same question kinda goes for description; since each package/crate normally has distinct description.
There was a problem hiding this comment.
Just for some background; I used your template which doesn't work if you omit the root description and name. This is also related to the cargo-doc PR. If you want to use a virtual root crate then nix develop fails.
At any rate, the name and description are inherited by member crates which means that you can always override the virtual root one. For my cases, they are always set, as you say. I don't see name mentioned as a supported key.. Perhaps instead relying on workspace.metadata.package-name and workspace.metadata.description for virtual-root is a more suitable fix, what do you think?
2 participants
No description provided.