Fixing issue #222: FaceLandmarks68 left and right eyes/brows are reversed. #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es/brows are reversed.
|
Sorry for the late reply on this one. I think it's better not to change the API, in order to not break anything for users of this package. Technically the terms left and right here are not wrong, they are just from an observers persepective. |
|
This API should be documented then to avoid surprises. |
|
Since we use typedoc, adding a comment in the function description would be helpful probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a "blind" fix, as I failed to build the library and run unit tests on my Windows box without Python (and I have no interest to install it). Up to you to verify and correct it.