Skip to content

feat(pie-docs): WEBEX-341 add sticky behaviour to docs site toggle component#2586

Open
xander-marjoram wants to merge 2 commits intomainfrom
webex-341-sticky-toggle
Open

feat(pie-docs): WEBEX-341 add sticky behaviour to docs site toggle component#2586
xander-marjoram wants to merge 2 commits intomainfrom
webex-341-sticky-toggle

Conversation

@xander-marjoram
Copy link
Copy Markdown
Contributor

@xander-marjoram xander-marjoram commented Oct 15, 2025

Describe your changes (can list changeset entries if preferable)

  • Add sticky behaviour to the toggle component on the docs site. This allows users to switch between different pages (e.g., light/dark tokens) without needing to scroll back to the top of the page, and then back down to where they were.
  • Update regular expressions to allow for longer Jira project ids

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 3f7dd6b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram marked this pull request as ready for review October 15, 2025 10:20
@xander-marjoram xander-marjoram requested a review from a team as a code owner October 15, 2025 10:20
@pie-design-system-bot
Copy link
Copy Markdown
Contributor




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 3f7dd6b

Copy link
Copy Markdown
Contributor

@jamieomaguire jamieomaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely love the idea for this change, so thank you for raising it!

I do think this would benefit from some input from our designers. As the current implementation can look a little jarring during scrolling and looks ever so slightly broken. Mostly because of a lack of background containing the switch, in my opinion.

Lets chat with design and see what we can do to get this change in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants