feat(pie-docs): WEBEX-341 add sticky behaviour to docs site toggle component#2586
feat(pie-docs): WEBEX-341 add sticky behaviour to docs site toggle component#2586xander-marjoram wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3f7dd6b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
jamieomaguire
left a comment
There was a problem hiding this comment.
I absolutely love the idea for this change, so thank you for raising it!
I do think this would benefit from some input from our designers. As the current implementation can look a little jarring during scrolling and looks ever so slightly broken. Mostly because of a lack of background containing the switch, in my opinion.
Lets chat with design and see what we can do to get this change in!
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.