Skip to content

feat(pie-docs): DSW-3725 add condition to help with monorepo support#2734

Open
ashleynolan wants to merge 2 commits intomainfrom
dsw-3725-skillupdate
Open

feat(pie-docs): DSW-3725 add condition to help with monorepo support#2734
ashleynolan wants to merge 2 commits intomainfrom
dsw-3725-skillupdate

Conversation

@ashleynolan
Copy link
Copy Markdown
Contributor

@ashleynolan ashleynolan commented Mar 25, 2026

Describe your changes (can list changeset entries if preferable)

[Changed] - Skill docs update and add condition to help with monorepo support

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • If there are visual test updates, I have reviewed them.

@ashleynolan ashleynolan requested a review from a team as a code owner March 25, 2026 22:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: 02599ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/pie-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

pie-design-system-bot commented Mar 25, 2026



Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 02599ad

Comment on lines +32 to +33
message: "We recommend installing the PIE Design System skill at 'Project', rather than 'Global' level.<br><br>Doing this means that the skill won't have to regenerate PIE documentation resources, when switching between applications locally."
} %}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i think this is a lot of white space :p
Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-03-26 at 09 15 38

Better? or Worse? I went with the whitespace as it's quite long on desktop screens, but don't mind much either way 😆

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants